fix: rule suggestions cause continuation in class body#20787
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
3 tasks
DMartens
reviewed
Apr 23, 2026
DMartens
reviewed
Apr 28, 2026
Contributor
|
Sorry for the delay. |
mdjermanovic
force-pushed
the
nouselessconstructor-generators
branch
from
April 28, 2026 18:40
c522ef9 to
6e7c478
Compare
Member
Author
Updated in d4d3cb1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment (
npx eslint --env-info):What parser are you using (place an "X" next to just one item)?
[x]
Default (Espree)[ ]
@typescript-eslint/parser[ ]
@babel/eslint-parser[ ]
vue-eslint-parser[ ]
@angular-eslint/template-parser[ ]
OtherPlease show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
The
no-useless-constructorrule to report the constructor as useless and provide a valid suggestion to remove it.What actually happened? Please include the actual, raw output from ESLint.
The
no-useless-constructorrule reports the constructor as useless and provides suggestion to remove it. However, applying the suggestion causes a parsing error:Playground link
The suggestion should insert a semicolon to prevent continuation.
What changes did you make? (Give an overview)
no-useless-constructorrule to use a new helperastUtils.canContinueExpressionInClassBody(token)that checks for the following tokens that can cause continuation:[,*,in,instanceof.require-awaitrule in the same way.astUtils.needsPrecedingSemicolonto avoid unnecessary semicolons in case of uninitialized class fields.Is there anything you'd like reviewers to focus on?