Fixed an issue with React giving warning about static children not having unique keys when using classic jsx factory - #2066
Merged
Conversation
…ving unique keys when using classic `jsx` factory
🦋 Changeset detectedLatest commit: 6d539e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Nov 2, 2020
| createElementArgArray[0] = Emotion | ||
| createElementArgArray[1] = createEmotionProps(type, props) | ||
|
|
||
| // https://github.com/facebook/react/blob/fd61f7ea53989a59bc427603798bb111c852816a/packages/react/src/ReactElement.js#L386-L400 |
Member
Author
There was a problem hiding this comment.
I'm kinda not sure why I have changed this logic to replicate what React is doing under the hood. I've implemented support for those new runtimes and refactor to the classic jsx a few months back, so 🤷♂️
Member
Author
|
@mitchellhamilton merging this as its sort of a hotfix |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2065