fix: devtools re-attaches on open when previously detached#50815
Merged
dsanders11 merged 1 commit intoApr 8, 2026
Conversation
PR #50646 added a dock state allowlist in SetDockState() that collapsed any non-matching value to "right". WebContents::OpenDevTools passes an empty string when no `mode` option is given, which is the sentinel LoadCompleted() uses to restore `currentDockState` from prefs. The allowlist clobbered that sentinel to "right", so previously-undocked devtools would flash detached and then snap back to the right dock. Preserve the empty string through SetDockState() so the pref-restore path runs; still reject any non-empty invalid value to keep the JS-injection guard from #50646 intact. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
4 tasks
dsanders11
approved these changes
Apr 8, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50807
See that PR for details.
Notes: Fixed an issue where DevTools would re-attach to the window when opened after previously being detached.