Skip to content

fix: don't force kFitToPrintableArea scaling when custom margins are set#50653

Merged
ckerr merged 1 commit into
42-x-yfrom
trop/42-x-y-bp-fix-don-t-force-kfittoprintablearea-scaling-when-custom-margins-are-set-1775155291084
Apr 3, 2026
Merged

fix: don't force kFitToPrintableArea scaling when custom margins are set#50653
ckerr merged 1 commit into
42-x-yfrom
trop/42-x-y-bp-fix-don-t-force-kfittoprintablearea-scaling-when-custom-margins-are-set-1775155291084

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop Bot commented Apr 2, 2026

Backport of #50615

See that PR for details.

Notes: Fixed an issue where margins did not look as expected when printing in silent mode.

When silent printing with non-default margins (custom, no margins, or
printable area margins), the kFitToPrintableArea scaling option causes
double-marginalization: the custom margins define the content area, then
the scaling additionally fits content to the printer's printable area.

Only apply kFitToPrintableArea when using default margins in silent mode.
For non-default margins, use the same scaling as non-silent prints.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop Bot requested a review from a team as a code owner April 2, 2026 18:41
@trop trop Bot requested review from a team and codebytere April 2, 2026 18:41
@trop trop Bot added 42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 2, 2026
@ckerr ckerr merged commit d73eaf8 into 42-x-y Apr 3, 2026
128 of 130 checks passed
@ckerr ckerr deleted the trop/42-x-y-bp-fix-don-t-force-kfittoprintablearea-scaling-when-custom-margins-are-set-1775155291084 branch April 3, 2026 15:26
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Apr 3, 2026

Release Notes Persisted

Fixed an issue where margins did not look as expected when printing in silent mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant