Skip to content

fix: possible crash in FileSystem API#49578

Merged
codebytere merged 1 commit into
mainfrom
fix-fsa-crash
Feb 3, 2026
Merged

fix: possible crash in FileSystem API#49578
codebytere merged 1 commit into
mainfrom
fix-fsa-crash

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Jan 29, 2026

Description of Change

Refs https://chromium-review.googlesource.com/6880247

Fixes a crash that can arise in the File System Access API in the following scenario:

  1. Create fileHandle1 at path1.
  2. Call fileHandle1.remove() or user manually delete the file.
  3. Create fileHandle2 at path2.
  4. fileHandle2.move(path1).

Checklist

Release Notes

Notes: Fixed a crash that could occur when using the File System Access API.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. labels Jan 29, 2026
@electron-cation electron-cation Bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Jan 29, 2026
deepak1556
deepak1556 approved these changes Jan 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a lint fix

@codebytere
fix: possible crash in FileSystem API
e2d853a 
Refs https://chromium-review.googlesource.com/6880247

Fixes a crash that can arise in the File System Access API in the
following scenario:

1. Create fileHandle1 at path1.
2. Call fileHandle1.remove() or user manually delete the file.
3. Create fileHandle2 at path2.
4. fileHandle2.move(path1).
@codebytere codebytere merged commit 86209f6 into main Feb 3, 2026
61 checks passed
@codebytere codebytere deleted the fix-fsa-crash branch February 3, 2026 14:15
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Feb 3, 2026

Release Notes Persisted

Fixed a crash that could occur when using the File System Access API.

This was referenced Feb 3, 2026
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Feb 3, 2026

I have automatically backported this PR to "39-x-y", please check out #49634

@trop trop Bot added the in-flight/39-x-y label Feb 3, 2026
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Feb 3, 2026

I have automatically backported this PR to "40-x-y", please check out #49635

@trop trop Bot removed the target/39-x-y PR should also be added to the "39-x-y" branch. label Feb 3, 2026
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Feb 3, 2026

I have automatically backported this PR to "41-x-y", please check out #49636

@trop trop Bot added in-flight/40-x-y in-flight/41-x-y and removed target/40-x-y PR should also be added to the "40-x-y" branch. target/41-x-y PR should also be added to the "41-x-y" branch. in-flight/41-x-y labels Feb 3, 2026
@trop trop Bot added merged/41-x-y PR was merged to the "41-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. and removed in-flight/40-x-y in-flight/39-x-y labels Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@dsanders11 dsanders11 Awaiting requested review from dsanders11

Assignees

No one assigned

Labels

merged/39-x-y PR was merged to the "39-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. merged/41-x-y PR was merged to the "41-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere @deepak1556