[vs18.9] Serialize BuildRequestConfiguration.RequestedTargets to fix solution metaproject MSB4057 in parallel builds - #14227
Merged
Conversation
In parallel/multithreaded builds a BuildRequestConfiguration is round-tripped through translation. RequestedTargets was a get-only auto-property that was never serialized, so the deserialized configuration reset it to an empty collection. SolutionProjectGenerator emits user-requested targets (e.g. Pack) into the generated .slnx.metaproj only when they are present in config.RequestedTargets. Losing them caused solution builds to fail with MSB4057 (target does not exist) under parallel/MT builds while serial builds worked. Back RequestedTargets with a serialized field and translate it in BuildRequestConfiguration.Translate. Adds a regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ViktorHofer
approved these changes
Jul 1, 2026
AlesProkop
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14223 to vs18.9
/cc @ViktorHofer