• feat: standardise sizes of ./site/static/icon/*.svg #21347 👈 (View in Graphite)
• feat: implement DEPRECATED_ICONS #21346
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

For ruby, the left is before, the right is after.

There you go, I stole this directly from ruby-lang.org's logo but it appears they still prefer the version found in "The Ruby Logo"

Treatment needed to be inverted here as the aws.png and aws.svg diverged previously, this is now uniform 🙂

I have some concerns about this, mostly from a process perspective

• What was the flow here? Did you do these by hand, in Figma, with an LLM, some other thing? From the second picture I'm guessing this was done in Figma by hand
• If we're going to enforce a correct size/padding/etc., how can we ensure that newly added icons conform in an automated manner?
• This might technically put us in a bad legal position, as many of the icons are trademarks and have restrictions around their use, including modification. It might be silly, but legally these are now all "modified" versions which might put us out of compliance.

What was the flow here? Did you do these by hand, in Figma, with an LLM, some other thing? From the second picture I'm guessing this was done in Figma by hand

Correct 🙂 Figma is my friend here.

If we're going to enforce a correct size/padding/etc., how can we ensure that newly added icons conform in an automated manner?

Biome doesn't contain SVG linting properties we can attach to here, we could extend upon ./scripts/check_site_icons.sh and ensure width="256", height="256" and viewBox="0 0 256 256" with a tiny little regex perhaps?

Perhaps the following for the PNGs

$ file do.png | grep -oE '[0-9]+\s*x\s*[0-9]+'
80 x 80

This might technically put us in a bad legal position, as many of the icons are trademarks and have restrictions around their use, including modification. It might be silly, but legally these are now all "modified" versions which might put us out of compliance.

I believe we're using these under fair-use. Honestly, the more common we'd ourselves violating the brand guidelines if we were to unfairly size one icon over the other when we render, this would be harder to mediate if we were battling various sizes.

I don't like putting actual business logic in shell scripts. they're too hard to write for novices and it's easy to miss silly things that will ruin your/someone else's day.

but I would love implementing a check like that in go, and I think that should be a prerequisite for this change. 😄

btw: no need for checking png resolution, we don't accept new png icons.