Fix thread-safety in AbstractDateAssert
#3874
Merged
+48
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@scordio I've applied the spotless code style changes, could you re-approve the pipeline? |
Member
|
@kelunik as we want to bring this fix in 3.27.4, I changed the target branch of this PR. I'll take care of rebasing your changes. |
Avoids synchronization need by using ThreadLocal. Fixes assertj#3873.
Contributor
Author
|
@scordio Had some time, so already did the rebase. |
Member
|
This is now merged. Many thanks for your first contribution, @kelunik! |
Contributor
Author
|
Thanks! |
AbstractDateAssert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids synchronization need by using ThreadLocal.
Fixes #3873.
Check List: