Create a single LauncherSession for invocations of JUnitPlatformProvider #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `JUnitPlatformProvider` created multiple `LauncherSessions` for some executions, for example when `forkTestSet` was `null` or when rerunning failed tests. This caused registered `LauncherSessionListeners` registered via `ServiceLoader` on the JUnit Platform to be called multiple times. As they are intended to set up and tear down resources, this had the potential of unnecessarily slowing down test execution.
Contributor
|
Hey @marcphilipp Thanks for the PR! Would you call this a bugfix (as not intended to use this way) or enhancement? |
Contributor
Author
|
I think it's not strictly a bug so I would call it an enhancement. 🙂 |
Member
|
Looks like an excellent change. Thanks for this. |
|
@olamy The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
JUnitPlatformProvidercreated multipleLauncherSessionsfor some executions, for example whenforkTestSetwasnullor when rerunning failed tests. This caused registeredLauncherSessionListenersregistered viaServiceLoaderon the JUnit Platform to be called multiple times. As they are intended to set up and tear down resources, this had the potential of unnecessarily slowing down test execution.Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.