[CODEC-343] Fix Base32 hex decode table builder#435
Open
OldTruckDriver wants to merge 1 commit into
Open
Conversation
Configure setHexDecodeTable(boolean) with the matching encode table instead of passing a decode lookup table to setEncodeTable(byte...). Add a regression test showing the configured codec encodes with the Base32-Hex alphabet and decodes its own output. Reviewed-by: OpenAI Codex Reviewed-by: Anthropic Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Base32.Builder#setHexDecodeTable(boolean)so it configures the matching Base32/Base32-Hex encode table instead of passing a decode lookup table tosetEncodeTable(byte...).Details
The previous implementation passed
decodeTable(useHex)intosetEncodeTable(...). Used on its own, this made the codec encode with a decode lookup table and emit invalid bytes.This change updates
setHexDecodeTable(boolean)to useencodeTable(useHex)and adds a regression test proving the configured codec encodes with the Base32-Hex alphabet and decodes its own output.Tests
mvn -q -Dtest=org.apache.commons.codec.binary.Base32Test testmvn -q javadoc:javadocmvn -q