Skip to content

fix(core): fix ng generate @angular/core:output-migration. #60763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aparzi wants to merge 1 commit into from
Closed

fix(core): fix ng generate @angular/core:output-migration. #60763

aparzi wants to merge 1 commit into from

Conversation

@aparzi
Copy link
Contributor

@aparzi aparzi commented Apr 6, 2025

insert a TODO comment for emit function with no parameters

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

After migration, event emitters of type @output that have a function with empty 'emit' (without any parameters) report an error because the 'emit' function expects a mandatory parameter.

Issue Number: #58650

What is the new behavior?

Insert a TODO comment for empty emit (without parameter).

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alxhub April 6, 2025 21:38
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 6, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 6, 2025
@aparzi aparzi force-pushed the fix-issue-58650 branch from 22dcb99 to 7e65dbb Compare April 7, 2025 15:35
@aparzi aparzi requested a review from JeanMeche April 7, 2025 15:36
@aparzi aparzi force-pushed the fix-issue-58650 branch from 7e65dbb to 2c756c6 Compare April 7, 2025 15:40
@JeanMeche JeanMeche changed the title fix(core): fix ng generate @angular/core:output-migration. Fixes #58650 fix(core): fix ng generate @angular/core:output-migration. Apr 7, 2025
@aparzi aparzi force-pushed the fix-issue-58650 branch from 2c756c6 to d207ea9 Compare April 7, 2025 19:50
@aparzi
fix(core): fix ng generate @angular/core:output-migration. Fixes angu…
b2421ed 
…lar#58650

Fixes angular#58650 - Insert a TODO comment for empty emit (without parameter).
@aparzi aparzi force-pushed the fix-issue-58650 branch from d207ea9 to b2421ed Compare April 7, 2025 20:19
@aparzi aparzi requested a review from JeanMeche April 7, 2025 20:19
@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub April 8, 2025 08:30
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 8, 2025
@atscott
Copy link
Contributor

atscott commented Apr 8, 2025

This PR was merged into the repository by commit 39a4e00.

The changes were merged into the following branches: main, 19.2.x

atscott pushed a commit that referenced this pull request Apr 8, 2025
@aparzi @atscott
fix(core): fix ng generate @angular/core:output-migration. Fixes #58650…
f2bfa31 
… (#60763)

Fixes #58650 - Insert a TODO comment for empty emit (without parameter).

PR Close #60763
@atscott atscott closed this in 39a4e00 Apr 8, 2025
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 9, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@aparzi @atscott @pkozlowski-opensource @JeanMeche