fix(language-service): Update adapter to log instead of throw errors #60651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Mar 31, 2025
This prevents errors from being thrown from the adapters. Throwing errors in the language service causes the extension to crash. Repeated errors will permanently break the extension. fixes angular/vscode-ng-language-service#2166
Contributor
|
caretaker note: test failures are green after de-flake. |
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 31, 2025
…60651) This prevents errors from being thrown from the adapters. Throwing errors in the language service causes the extension to crash. Repeated errors will permanently break the extension. fixes angular/vscode-ng-language-service#2166 PR Close #60651
Contributor
|
This PR was merged into the repository by commit ea62a4f. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents errors from being thrown from the adapters. Throwing errors in the language service causes the extension to crash. Repeated errors will permanently break the extension.
fixes angular/vscode-ng-language-service#2166