Skip to content

Conversation

@aparzi
Copy link
Contributor

@aparzi aparzi commented Mar 19, 2025

After running the control flow migration, used templates are not deleted.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

After running the control flow migration, used templates are not deleted. I also replaced the implementation of template search from regex via AST

Issue Number: #56965

What is the new behavior?

Expected result would be that the used template is removed.

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 19, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2025
@aparzi
Copy link
Contributor Author

aparzi commented Mar 19, 2025

Hi @JeanMeche,
I'm fixing the problem indicated in the description. The main problem is in the regex that in my opinion should be replaced with an implementation that uses the AST html, which I did, but two test cases fail. Specifically:

  • should migrate ngForTemplate when template is only used once
  • should migrate multiple if/else using the same ng-template

Thanks

@aparzi aparzi marked this pull request as ready for review March 24, 2025 00:08
@aparzi aparzi requested a review from JeanMeche March 24, 2025 00:08
@pullapprove pullapprove bot requested a review from crisbeto March 24, 2025 00:08
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

After running the control flow migration, used templates are not deleted.
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 24, 2025
@alxhub
Copy link
Member

alxhub commented Mar 24, 2025

This PR was merged into the repository by commit cf5c61c.

The changes were merged into the following branches: main, 19.2.x

@alxhub alxhub closed this in cf5c61c Mar 24, 2025
alxhub pushed a commit that referenced this pull request Mar 24, 2025
After running the control flow migration, used templates are not deleted.

PR Close #60459
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants