Skip to content

fix(router): Add missing types to transition #60307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atscott wants to merge 1 commit into from
Closed

fix(router): Add missing types to transition #60307

atscott wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Mar 10, 2025

The 'types' property was added recently and is available in all browsers that support view transitions

fixes #60285

@atscott atscott added area: router target: patch This PR is targeted for the next patch release labels Mar 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 10, 2025
@pullapprove pullapprove bot requested review from alxhub, kirjs and mmalerba March 10, 2025 16:45
@atscott
fix(router): Add missing types to transition
501363b 
The 'types' property was added recently and is available in all browsers that support view transitions

fixes angular#60285
AndrewKushnir
AndrewKushnir approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

kirjs
kirjs approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 27, 2025
@atscott
Copy link
Contributor Author

atscott commented Mar 27, 2025

caretaker note: unrelated failure in presubmit

@thePunderWoman thePunderWoman removed the request for review from alxhub March 28, 2025 11:50
thePunderWoman pushed a commit that referenced this pull request Mar 28, 2025
@atscott @thePunderWoman
fix(router): Add missing types to transition (#60307)
958e98e 
The 'types' property was added recently and is available in all browsers that support view transitions

fixes #60285

PR Close #60307
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Mar 28, 2025

This PR was merged into the repository by commit 1226eaa.

The changes were merged into the following branches: main, 19.2.x

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 28, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirjs kirjs kirjs approved these changes

@mmalerba mmalerba mmalerba approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Support view transition types

5 participants

@atscott @thePunderWoman @kirjs @mmalerba @AndrewKushnir