fix(core): ensures immediate trigger fires properly with lazy loaded routes #60203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fdda88 to
ba4ffdf
Compare
c501d5b to
b185589
Compare
…routes In the case that a route was lazy loaded, some triggers would never properly finish hydrating due to things firing before the route finished resolving. This will find the topmost parent defer block and ensure the registry knows about it before trying to hydrate. In the case that the registry does not yet know, just the affected triggers await app stability before initializing. fixes angular#59997
AndrewKushnir
approved these changes
Mar 6, 2025
Contributor
|
This PR was merged into the repository by commit c823841. The changes were merged into the following branches: main, 19.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 6, 2025
…routes (#60203) In the case that a route was lazy loaded, some triggers would never properly finish hydrating due to things firing before the route finished resolving. This will find the topmost parent defer block and ensure the registry knows about it before trying to hydrate. In the case that the registry does not yet know, just the affected triggers await app stability before initializing. fixes #59997 PR Close #60203
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that a route was lazy loaded, some triggers would never properly finish hydrating due to things firing before the route finished resolving. This will find the topmost parent defer block and ensure the registry knows about it before trying to hydrate. In the case that the registry does not yet know, just the affected triggers await app stability before initializing. fixes #59997
Does this PR introduce a breaking change?