fix(core): check whether application is destroyed before initializing event replay #59789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
930486b to
4dd459d
Compare
fd11c74 to
c58d598
Compare
Contributor
|
@arturovt If you can resolve the conflicts here, I can take a look and get this closer to landing. |
… event replay In this commit, we check whether the application is destroyed before initializing event replay. The application may be destroyed before it becomes stable, so when the `whenStable` resolves, the injector might already be in a destroyed state. As a result, calling `injector.get` would throw an error indicating that the injector has already been destroyed.
c58d598 to
44cbfed
Compare
Contributor
|
Caretaker note: the failing G3 tests are unrelated to this change. This is safe to merge. |
Contributor
|
This PR was merged into the repository by commit 79ae355. The changes were merged into the following branches: main, 19.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 5, 2025
… event replay (#59789) In this commit, we check whether the application is destroyed before initializing event replay. The application may be destroyed before it becomes stable, so when the `whenStable` resolves, the injector might already be in a destroyed state. As a result, calling `injector.get` would throw an error indicating that the injector has already been destroyed. PR Close #59789
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we check whether the application is destroyed before initializing event replay. The application may be destroyed before it becomes stable, so when the
whenStableresolves, the injector might already be in a destroyed state. As a result, callinginjector.getwould throw an error indicating that the injector has already been destroyed.