Skip to content

fix(migrations): CF Migration fix missing alias for bound ngifs#53296

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:ngif
Closed

fix(migrations): CF Migration fix missing alias for bound ngifs#53296
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:ngif

Conversation

@jessicajaniuk
Copy link
Contributor

Empty aliases are considered the item in an ngFor, and ngIf was skipping that value.

fixes: #53291

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 30, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 30, 2023
Empty aliases are considered the item in an ngFor, and ngIf was skipping that value.

fixes: angular#53291
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Dec 5, 2023

This PR was merged into the repository by commit 6f75471.

@dylhunn dylhunn closed this in 6f75471 Dec 5, 2023
dylhunn pushed a commit that referenced this pull request Dec 5, 2023
Empty aliases are considered the item in an ngFor, and ngIf was skipping that value.

fixes: #53291

PR Close #53296
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 5, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…lar#53296)

Empty aliases are considered the item in an ngFor, and ngIf was skipping that value.

fixes: angular#53291

PR Close angular#53296
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…lar#53296)

Empty aliases are considered the item in an ngFor, and ngIf was skipping that value.

fixes: angular#53291

PR Close angular#53296
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…lar#53296)

Empty aliases are considered the item in an ngFor, and ngIf was skipping that value.

fixes: angular#53291

PR Close angular#53296
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control flow schematic: ng-template + [ngIf] + let- not migrated correctly

4 participants

Comments