fix(core): handle hydration of multiple nodes projected in a single slot#53270
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): handle hydration of multiple nodes projected in a single slot#53270AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
This commit updates the logic to handle hydration of multiple nodes projected in a single slot. Currently, in case component nodes are content-projected and their order is changed during the projection, hydration can not find the correct element. With this fix, extra annotation info would be included for such nodes and hydration logic at runtime will use it to locate the right element. Resolves angular#53246.
9859c92 to
6737ecb
Compare
jessicajaniuk
approved these changes
Nov 29, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM! Glad this is a fairly simple fix.
Contributor
Author
Contributor
|
This PR was merged into the repository by commit 899f6c4. |
dylhunn
pushed a commit
that referenced
this pull request
Nov 30, 2023
…lot (#53270) This commit updates the logic to handle hydration of multiple nodes projected in a single slot. Currently, in case component nodes are content-projected and their order is changed during the projection, hydration can not find the correct element. With this fix, extra annotation info would be included for such nodes and hydration logic at runtime will use it to locate the right element. Resolves #53246. PR Close #53270
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…lot (angular#53270) This commit updates the logic to handle hydration of multiple nodes projected in a single slot. Currently, in case component nodes are content-projected and their order is changed during the projection, hydration can not find the correct element. With this fix, extra annotation info would be included for such nodes and hydration logic at runtime will use it to locate the right element. Resolves angular#53246. PR Close angular#53270
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…lot (angular#53270) This commit updates the logic to handle hydration of multiple nodes projected in a single slot. Currently, in case component nodes are content-projected and their order is changed during the projection, hydration can not find the correct element. With this fix, extra annotation info would be included for such nodes and hydration logic at runtime will use it to locate the right element. Resolves angular#53246. PR Close angular#53270
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…lot (angular#53270) This commit updates the logic to handle hydration of multiple nodes projected in a single slot. Currently, in case component nodes are content-projected and their order is changed during the projection, hydration can not find the correct element. With this fix, extra annotation info would be included for such nodes and hydration logic at runtime will use it to locate the right element. Resolves angular#53246. PR Close angular#53270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the logic to handle hydration of multiple nodes projected in a single slot. Currently, in case component nodes are content-projected and their order is changed during the projection, hydration can not find the correct element. With this fix, extra annotation info would be included for such nodes and hydration logic at runtime will use it to locate the right element.
Resolves #53246.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?