Skip to content

fix(migrations): handle aliases on bound ngIf migrations#53261

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-let
Closed

fix(migrations): handle aliases on bound ngIf migrations#53261
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:migration-let

Conversation

@jessicajaniuk
Copy link
Contributor

This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: #53251

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: angular#53251
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 29, 2023
@ngbot ngbot bot modified the milestone: Backlog Nov 29, 2023
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 29, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Nov 30, 2023

This PR was merged into the repository by commit f4a96a9.

@dylhunn dylhunn closed this in f4a96a9 Nov 30, 2023
dylhunn pushed a commit that referenced this pull request Nov 30, 2023
This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: #53251

PR Close #53261
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: angular#53251

PR Close angular#53261
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: angular#53251

PR Close angular#53261
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
This fixes a reported issue where ngIf is used on an ng-template with let aliases.

fixes: angular#53251

PR Close angular#53261
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control flow schematic: [ngIf] + let- not migrated

4 participants

Comments