fix(router): Ensure canMatch guards run on wildcard routes#53239
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): Ensure canMatch guards run on wildcard routes#53239atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
This commit makes sure that wildcard routes still run the `canMatch` guards. Fixes angular#49949
6f97d8f to
e0346bb
Compare
AndrewKushnir
approved these changes
Nov 30, 2023
Contributor
|
This PR was merged into the repository by commit 1940280. |
dylhunn
pushed a commit
that referenced
this pull request
Nov 30, 2023
dylhunn
added a commit
to dylhunn/angular
that referenced
this pull request
Dec 3, 2023
…ngular#53239)" This reverts commit 1940280.
dylhunn
added a commit
that referenced
this pull request
Dec 3, 2023
dylhunn
added a commit
that referenced
this pull request
Dec 3, 2023
atscott
added a commit
to atscott/angular
that referenced
this pull request
Dec 4, 2023
…outes (angular#53239)" (angular#53339)" This reverts commit ac8eb5b.
dylhunn
pushed a commit
that referenced
this pull request
Dec 6, 2023
dylhunn
pushed a commit
that referenced
this pull request
Dec 6, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…3239) This commit makes sure that wildcard routes still run the `canMatch` guards. Fixes angular#49949 PR Close angular#53239
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
…3239) This commit makes sure that wildcard routes still run the `canMatch` guards. Fixes angular#49949 PR Close angular#53239
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
…3239) This commit makes sure that wildcard routes still run the `canMatch` guards. Fixes angular#49949 PR Close angular#53239
danielwiehl
added a commit
to SchweizerischeBundesbahnen/scion-workbench
that referenced
this pull request
Apr 12, 2024
danielwiehl
added a commit
to SchweizerischeBundesbahnen/scion-workbench
that referenced
this pull request
May 7, 2024
…ngular#53239 BREAKING CHANGE: SCION Workbench requires Angular version 17.0.6 or later to fix angular/angular#53239
Marcarrian
pushed a commit
to SchweizerischeBundesbahnen/scion-workbench
that referenced
this pull request
May 7, 2024
…ngular#53239 BREAKING CHANGE: SCION Workbench requires Angular version 17.0.6 or later to fix angular/angular#53239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes sure that wildcard routes still run the
canMatchguards.Fixes #49949