Handle nested classes in migrations#52309
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
Conversation
Fixes that the block entities migration was only processing top-level classes. Nested classes could come up during unit tests.
Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests.
744d4fa to
2b82d34
Compare
Member
Author
|
Caretaker note: this one passed the presubmit earlier, but I had to push again to resolve merge conflicts. |
Contributor
|
This PR was merged into the repository by commit c993e9a. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 24, 2023
) Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests. PR Close #52309
dylhunn
pushed a commit
that referenced
this pull request
Oct 24, 2023
) Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests. PR Close #52309
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#52309) Fixes that the block entities migration was only processing top-level classes. Nested classes could come up during unit tests. PR Close angular#52309
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ular#52309) Fixes that the control flow migration was only processing top-level classes. Nested classes could come up during unit tests. PR Close angular#52309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates a couple of migrations that were only looking at classes defined at the top level of the file.