fix(core): do not remove used ng-template nodes in control flow migration#52186
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): do not remove used ng-template nodes in control flow migration#52186cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
…tion This fixes an issue where `ng-template` nodes were removed even when used in other places than control flow directives. Template to migrate: ```html <ng-template #blockUsedElsewhere><div>Block</div></ng-template> <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` Before: ```html <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` After: ```html <ng-template #blockUsedElsewhere><div>Block</div></ng-template> <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ```
dylhunn
approved these changes
Oct 12, 2023
Member
|
This PR was merged into the repository by commit 20e7e21. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Oct 12, 2023
…tion (#52186) This fixes an issue where `ng-template` nodes were removed even when used in other places than control flow directives. Template to migrate: ```html <ng-template #blockUsedElsewhere><div>Block</div></ng-template> <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` Before: ```html <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` After: ```html <ng-template #blockUsedElsewhere><div>Block</div></ng-template> <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` PR Close #52186
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…tion (angular#52186) This fixes an issue where `ng-template` nodes were removed even when used in other places than control flow directives. Template to migrate: ```html <ng-template #blockUsedElsewhere><div>Block</div></ng-template> <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` Before: ```html <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` After: ```html <ng-template #blockUsedElsewhere><div>Block</div></ng-template> <ng-container *ngTemplateOutlet="blockUsedElsewhere"></ng-container> ``` PR Close angular#52186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This fixes an issue where
ng-templatenodes were removed even when used in other places than control flow directives.Template to migrate:
Before:
What is the new behavior?
After:
Does this PR introduce a breaking change?
Other information