Skip to content

perf(compiler): further reduce bundle size using arrow functions#52010

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:more-arrow-functions
Closed

perf(compiler): further reduce bundle size using arrow functions#52010
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:more-arrow-functions

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 4, 2023

Reworks a few more places to output arrow functions instead of function declarations in order to reduce the amount of code we generate. Some of these places include:

  • Factories in injectable definitions.
  • Forward references.
  • dependencies function in the component definition.
  • consts function in the component definition.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 4, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 4, 2023
Reworks a few more places to output arrow functions instead of function declarations in order to reduce the amount of code we generate. Some of these places include:
* Factories in injectable definitions.
* Forward references.
* `dependencies` function in the component definition.
* `consts` function in the component definition.
@crisbeto crisbeto force-pushed the more-arrow-functions branch from 1b0cf0e to aeb7da4 Compare October 4, 2023 11:31
@crisbeto crisbeto marked this pull request as ready for review October 4, 2023 12:59
@crisbeto crisbeto requested a review from devversion October 4, 2023 13:00
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 4, 2023
@alxhub
Copy link
Member

alxhub commented Oct 4, 2023

This PR was merged into the repository by commit e5bca43.

@alxhub alxhub closed this in e5bca43 Oct 4, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…ular#52010)

Reworks a few more places to output arrow functions instead of function declarations in order to reduce the amount of code we generate. Some of these places include:
* Factories in injectable definitions.
* Forward references.
* `dependencies` function in the component definition.
* `consts` function in the component definition.

PR Close angular#52010
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments