Skip to content

feat(compiler): extract api docs for interfaces#52006

Closed
jelbourn wants to merge 1 commit intoangular:mainfrom
jelbourn:interfaces-and-types
Closed

feat(compiler): extract api docs for interfaces#52006
jelbourn wants to merge 1 commit intoangular:mainfrom
jelbourn:interfaces-and-types

Conversation

@jelbourn
Copy link
Contributor

@jelbourn jelbourn commented Oct 4, 2023

This adds API doc extraction for interfaces, largely using the same code paths for classes. The primary difference between classes and interfaces is that classes have member declarations while interfaces have member signatures. This largely doesn't matter for the purposes of extraction, but the types are distinct with no common base types, so we have to do a fair amount of type unioning and aliasing.

This adds API doc extraction for interfaces, largely using the same code paths for classes. The primary difference between classes and interfaces is that classes have member _declarations_ while interfaces have member _signatures_. This largely doesn't matter for the purposes of extraction, but the types are distinct with no common base types, so we have to do a fair amount of type unioning and aliasing.
@jelbourn jelbourn added area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels Oct 4, 2023
@ngbot ngbot bot added this to the Backlog milestone Oct 4, 2023
@pullapprove pullapprove bot requested a review from dylhunn October 4, 2023 01:01
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 4, 2023
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2023
@alxhub
Copy link
Member

alxhub commented Oct 4, 2023

This PR was merged into the repository by commit a7fa253.

@alxhub alxhub closed this in a7fa253 Oct 4, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
This adds API doc extraction for interfaces, largely using the same code paths for classes. The primary difference between classes and interfaces is that classes have member _declarations_ while interfaces have member _signatures_. This largely doesn't matter for the purposes of extraction, but the types are distinct with no common base types, so we have to do a fair amount of type unioning and aliasing.

PR Close angular#52006
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments