feat(common): upgrade warning to logged error for lazy-loaded LCP images#52004
Closed
atcastle wants to merge 1 commit intoangular:mainfrom
Closed
feat(common): upgrade warning to logged error for lazy-loaded LCP images#52004atcastle wants to merge 1 commit intoangular:mainfrom
atcastle wants to merge 1 commit intoangular:mainfrom
Conversation
…ges using NgOptimizedImage Upgrade the existing warning so it now logs an error instead, when an LCP element is determined to not be usings the `priority` attribute. Error is logged, not thrown.
AndrewKushnir
approved these changes
Oct 3, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@atcastle thanks Alex!
Contributor
|
TGP. |
Contributor
|
FYI, TGP is "green". |
Contributor
|
Caretaker note: TGP is "green", this PR is ready for merge. |
Member
|
This PR was merged into the repository by commit dde3fda. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ges using NgOptimizedImage (angular#52004) Upgrade the existing warning so it now logs an error instead, when an LCP element is determined to not be usings the `priority` attribute. Error is logged, not thrown. PR Close angular#52004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the existing warning when an NgOptimizedImage is discovered to be the LCP element and not given the
priorityattribute to an error. Not usingprioritycauses the LCP image to be lazy-loaded and can significantly hurt image performance. This error is only logged in dev.This PR is a pared-back version of #51748. As this error is logged, not thrown, it is no longer a breaking change and does not require the functionality to turn the error off in testbed scenarios. CC: @AndrewKushnir