Closed
Conversation
crisbeto
commented
Oct 3, 2023
Member
Author
There was a problem hiding this comment.
I decided to delete this test since cases like this are now parsing errors. This is accounted for already in the automated migration.
78bc387 to
96bd8c9
Compare
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Oct 3, 2023
…plate Fixes that the starter template would've generated a compilation error in v17 after angular/angular#51994 is released.
96bd8c9 to
1ae2b96
Compare
Member
Author
|
Caretaker note: cl/570327778 will have to be patched together with this change to disable blocks internally. |
Member
Author
|
Mostly passing TGP. There are a handful of failing targets, but they're due to issues with the target itself. |
1ae2b96 to
f4a2d54
Compare
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979).
f4a2d54 to
e39e0c6
Compare
Member
|
This PR was merged into the repository by commit 43e6fb0. |
clydin
pushed a commit
to angular/angular-cli
that referenced
this pull request
Oct 4, 2023
…plate Fixes that the starter template would've generated a compilation error in v17 after angular/angular#51994 is released.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Enables the new `@` block syntax by default by removing the `enabledBlockTypes` flags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see angular#51979). PR Close angular#51994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the new
@block syntax by default by removing theenabledBlockTypesflags. There are still some internal flags that allow special use cases to opt out of the block syntax, like during XML parsing and when compiling older libraries (see #51979).