Skip to content

fix(service-worker): throw a critical error when handleFetch fails #51885 for 15.2 Branch#51923

Closed
janniemeyer wants to merge 1 commit intoangular:15.2.xfrom
janniemeyer:patch-1
Closed

fix(service-worker): throw a critical error when handleFetch fails #51885 for 15.2 Branch#51923
janniemeyer wants to merge 1 commit intoangular:15.2.xfrom
janniemeyer:patch-1

Conversation

@janniemeyer
Copy link

Apply the workaround approved for Angular 16 to Angular 15 as in #51885

Original description:

On Safari, the cache might fail on methods like match with an Internal error. Critical errors allows to fallback to safeFetch() in the Driver.

fixes: #50378

NB: This caching will still be broken since apparantly there a bug on Safari. This fix will only allow the app to recover from the bug. It can be considered as a workaround.

…ngular#51885).

Apply the workaround approved for Angular 16 to Angular 15 as in angular@c3d901e

Original description:
On Safari, the cache might fail on methods like `match` with an `Internal error`. Critical errors allows to fallback to `safeFetch()` in the `Driver`.

fixes: angular#50378

PR Close angular#51885
@google-cla
Copy link

google-cla bot commented Sep 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from alxhub September 27, 2023 10:56
@dylhunn dylhunn added the area: service-worker Issues related to the @angular/service-worker package label Sep 27, 2023
@ngbot ngbot bot added this to the Backlog milestone Sep 27, 2023
@JeanMeche
Copy link
Member

JeanMeche commented Sep 29, 2023

@janniemeyer Could amend you commit and include the same change as #51960 ?

It turns out that the initial fix in #51885 isn't enough

@JeanMeche
Copy link
Member

I've opened #51989 which includes both changes.

@JeanMeche JeanMeche closed this Oct 2, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: service-worker Issues related to the @angular/service-worker package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments