feat(animations): Provide a way to lazy load the animations#50738
Closed
JeanMeche wants to merge 3 commits intoangular:mainfrom
Closed
feat(animations): Provide a way to lazy load the animations#50738JeanMeche wants to merge 3 commits intoangular:mainfrom
JeanMeche wants to merge 3 commits intoangular:mainfrom
Conversation
1e600bb to
9eb4b94
Compare
9eb4b94 to
bc81f84
Compare
22e43cc to
a3b6b41
Compare
7456abb to
c773b6c
Compare
7766964 to
52424c2
Compare
a76ee9c to
5b8836b
Compare
7acd70a to
62da920
Compare
dylhunn
approved these changes
Sep 27, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Contributor
|
TGP is green. This is ready to merge. |
Member
|
This PR was merged into the repository by commit 81e7f5b. |
alxhub
pushed a commit
that referenced
this pull request
Sep 29, 2023
) This integration test aims to cover that we do not break the code splitting of the animation module when we use `provideAnimationsAsync()`. PR Close #50738
alxhub
pushed a commit
that referenced
this pull request
Sep 29, 2023
Let's have the same test app for async and eagerly loaded animations. PR Close #50738
Contributor
|
was it renamed to |
Contributor
|
@robertIsaac yes, it was. |
Contributor
|
I tried it, but saw size increases instead of decrease |
Contributor
|
@robertIsaac Please file an issue with the repro and we can take a look. |
Member
Author
|
@robertIsaac Please open an new issue with a repro repo and we'll happily investigate that 😊 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
angular#50738) `provideLazyLoadedAnimations()` returns providers which allow the lazy loading of the animation module. Lazy loading of the animation code can shave off up to 16KB gzipped of the main bundle. PR Close angular#50738
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ular#50738) This integration test aims to cover that we do not break the code splitting of the animation module when we use `provideAnimationsAsync()`. PR Close angular#50738
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Let's have the same test app for async and eagerly loaded animations. PR Close angular#50738
PowerKiKi
referenced
this pull request
in unil-lettres/dilps-tiresias
Jun 30, 2025
If `showHideRelatedCards` is refactored into native CSS, then the package `@angular/animations` could be dropped entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #50399, this work here is a proposition to allow the lazy loading of animations code that can shave off up to 16KB gzipped of the main bundle !
The PR introduces a new entry point in the
platform-browserpackage :lazy-animations. This has been necessary because the eager providers (BROWSER_ANIMATIONS_PROVIDERSandBROWSER_NOOP_ANIMATIONS_PROVIDERS) were retaining symbols from@angular/animation/browsermaking the code splitting & lazy loading impossible.In this entry point, you will find the new
provideLazyLoadingAnimations()function which will provide a newRendererFactory2:AsyncAnimationRendererFactory.AsyncAnimationRendererFactorywill create a newDynamicDelegationRendererwhich will delegate to the default renderer by default.Aside from the renderer, the new factory will lazily import the
@angular/animations/browser. Once the package is loaded, the factory will switch the delegate ofDynamicDelegationRendererto anAnimationRenderer.The side effect of this implementation is that the rendering might not include the styles from the animations defined in components until the module is loaded. This should an acceptable drawback.
Also, I'd like to thank @AndrewKushnir for his help on this PR.
PR Type
Does this PR introduce a breaking change?