fix(forms): reset() call with null values on nested group#48830
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(forms): reset() call with null values on nested group#48830JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
Non typed forms allow to pass null to nested groups when calling `formGroup.reset()`, this commit prevent an undefined access. fixes angular#20509
21ba578 to
a81ab80
Compare
dylhunn
approved these changes
Oct 10, 2023
Contributor
|
caretaker: windows is a flake. |
Contributor
|
This PR was merged into the repository by commit ddd7212. |
atscott
pushed a commit
that referenced
this pull request
Oct 10, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
) Non typed forms allow to pass null to nested groups when calling `formGroup.reset()`, this commit prevent an undefined access. fixes angular#20509 PR Close angular#48830
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non typed forms allow to pass null to nested groups when calling
formGroup.reset(), this commit prevents an undefined access.fixes #20509
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?