fix: only parse arguments from first line of tag comment#1650
Merged
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom Jul 17, 2025
aabajyan:fix-tag-first-line
Merged
fix: only parse arguments from first line of tag comment#1650Perryvw merged 1 commit intoTypeScriptToLua:masterfrom aabajyan:fix-tag-first-line
Perryvw merged 1 commit intoTypeScriptToLua:masterfrom
aabajyan:fix-tag-first-line
Conversation
Contributor
|
nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example:
Would result in:
The solution was pretty simple, I only had to get the first line before splitting it by space.
I ran the tests and everything passes. Let me know if there's other changes I need to make.