chore: Config::getFinder() - fix typehinting
#9288
Merged
+30
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
fyi @mlocati |
mlocati
reviewed
Dec 10, 2025
| $config->getFinder() | ||
| $finder = $config->getFinder(); | ||
|
|
||
| assert($finder instanceof Finder); // Config::getFinder() ensures only `iterable` |
Contributor
There was a problem hiding this comment.
Why assert() instead of self::assertInstanceOf() ?
Member
Author
There was a problem hiding this comment.
this assertion was not added because of test case assertions needs, but because of PHPStan
we use assert when we want to hint PHPStan on the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before playing with SplFileInfo vs Symfony\Finder\SplFileInfo, let's clean up the actual type in config