bound WMS exception response copy to result_size in msDrawWMSLayerLow#7578
Open
nvxbug wants to merge 1 commit into
Open
bound WMS exception response copy to result_size in msDrawWMSLayerLow#7578nvxbug wants to merge 1 commit into
nvxbug wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cascaded WMS server returns an XML exception, msDrawWMSLayerLow copies the response into a fixed szBuf with strlcpy(szBuf, result_data, MS_BUFFER_LENGTH). result_data is assembled in msHTTPWriteFct by memcpy of exactly result_size bytes and is never NUL-terminated (the +10000 slack from msSmallMalloc is uninitialized heap). strlcpy scans the source for a NUL to compute its length, so it walks past result_size into uninitialized or adjacent heap, and those bytes then land in the msSetError/msDebug message. A malicious or compromised upstream server sending a NUL-free text/xml body on the default in-memory path triggers it.
Copy result_size bytes and terminate explicitly, the way the sibling result_data consumers a few lines down already do. Keeping the length bound at the copy site is the only place that knows the real byte count, since the buffer past result_size is not part of the response.