feat(Geometries): PolyBezierSegment#16664
Conversation
|
You can test this PR using the following package version. |
| points[i + 2], | ||
| isStroken); | ||
| } | ||
| var delta = i - points.Count; |
There was a problem hiding this comment.
I think WPF doesn't trigger a warning in this case and simply silently skips the points
https://github.com/dotnet/wpf/blob/e7ddcf41e1342d889aa7273b836909bdf15154e2/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/ByteStreamGeometryContext.cs#L651-L657
There was a problem hiding this comment.
I saw that. I thought it would be helpful for developers to have feedback if they were using incorrect values so they could more easily look for bugs.
Do I remove the warning?
|
You can test this PR using the following package version. |
maxkatz6
left a comment
There was a problem hiding this comment.
I am fine with keeping the warning.
LGTM otherwise.
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Closes #12741