DataGrid: expose row index#15909
Merged
Merged
Conversation
|
You can test this PR using the following package version. |
Collaborator
|
Contributor
Author
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
Contributor
|
What are the performance implications if you insert or remove the first row of a 100k row |
Member
|
It should affect only rows that are currently materialized. |
maxkatz6
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Make DataGridRow.Index public get-able.
What is the current behavior?
It's hard to show row number.
What is the updated/expected behavior with this PR?
User can use below binding to show row index.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
I think no.
Obsoletions / Deprecations
GetIndexmethod is obsoleted, should be replaced byIndexpropertyFixed issues