fix copy/paste of non-http links in Notes#452
Merged
Conversation
dstillman
added a commit
that referenced
this pull request
Feb 5, 2014
fix copy/paste of non-http links in Notes
Member
|
Thanks! |
dstillman
added a commit
that referenced
this pull request
Apr 10, 2015
Copying zotero:// and other non-HTTP links from a note itself was fixed in #452, but copying such links from other sources still stripped the hrefs. This removes the patch in #452 and just gets the HTML directly from the clipboard. I'm not sure why TinyMCE doesn't try to do this by default (it only tries for plaintext), so maybe there's a problem with this approach, but it seems to work for me (strips bad HTML, etc.). Fixes #697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
copy+paste within notes removes non-http links. So the html code
<a href="zotero://select/items/0_DQHBAGPE">link</a>becomes<a>link</a>when I copy and paste it within notes. http links, however, work without a problem. It's probably some obscure tinymce bug. It works in Chrome but it doesn't in firefox. This pull request fixes the bug with a small addition in the paste plugin. I had to replace the minified version with the full one and then changed the part which is earmarked with an// Added by Zotero.