Fix SSR manifest placeholder not replaced when server build is minified - #17874
Merged
Merged
Conversation
Rolldown's minifier rewrites string literals as template literals (backticks), but the regex matching the `@@ASTRO_MANIFEST_REPLACE@@` placeholder only accepted single and double quotes. Add backtick to the character class in the manifest and server islands replacement regexes. Fixes #17843
🦋 Changeset detectedLatest commit: 32b2860 The changes in this PR will be included in the next version bump. This PR includes changesets to release 423 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will improve performance by 19.21%
Performance Changes
Tip Curious why performance improved? Comment Comparing 
Footnotes |
matthewp
approved these changes
Aug 31, 2026
Merged
dadezzz
pushed a commit
to dadezzz/university_notes
that referenced
this pull request
Sep 4, 2026
![Renovate [bot]](/proxy?url=https%3A%2F%2Fgithub.githubassets.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@astrojs/markdown-remark](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/markdown/remark)) | [`7.2.4` → `7.3.0`](https://renovatebot.com/diffs/npm/@astrojs%2fmarkdown-remark/7.2.4/7.3.0) |  |  | | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`7.2.9` → `7.2.10`](https://renovatebot.com/diffs/npm/astro/7.2.9/7.2.10) |  |  | --- ### Release Notes <details> <summary>withastro/astro (@​astrojs/markdown-remark)</summary> ### [`v7.3.0`](https://github.com/withastro/astro/blob/HEAD/packages/markdown/remark/CHANGELOG.md#730) [Compare Source](https://github.com/withastro/astro/compare/@astrojs/markdown-remark@7.2.4...@astrojs/markdown-remark@7.3.0) ##### Minor Changes - [#​17262](withastro/astro#17262) [`f8e9458`](withastro/astro@f8e9458) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Adds MDX rendering to the `unified()` and `satteri()` processors. Both processors now compile `.mdx` files themselves. You still need to install `@astrojs/mdx` to add MDX support to your project. - [#​17262](withastro/astro#17262) [`f8e9458`](withastro/astro@f8e9458) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Adds a `recmaPlugins` option to `unified()` for adding recma (estree/JSX) plugins to the MDX compiler. ##### Patch Changes - Updated dependencies \[[`f8e9458`](withastro/astro@f8e9458)]: - [@​astrojs/internal-helpers](https://github.com/astrojs/internal-helpers)@0.11.0 </details> <details> <summary>withastro/astro (astro)</summary> ### [`v7.2.10`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#7210) [Compare Source](https://github.com/withastro/astro/compare/astro@7.2.9...astro@7.2.10) ##### Patch Changes - [#​17262](withastro/astro#17262) [`f8e9458`](withastro/astro@f8e9458) Thanks [@​Princesseuh](https://github.com/Princesseuh)! - Fixes `@astrojs/markdown-remark` being pinned to an exact version. - [#​17874](withastro/astro#17874) [`10c7e63`](withastro/astro@10c7e63) Thanks [@​astro-factory](https://github.com/apps/astro-factory)! - Fixes SSR manifest placeholder not being replaced when the server build is minified, which caused a runtime `Invalid URL` crash at server boot - [#​17869](withastro/astro#17869) [`2548abf`](withastro/astro@2548abf) Thanks [@​ematipico](https://github.com/ematipico)! - Fixes a case where the logger was improperly initialized at runtime in dev. - [#​17878](withastro/astro#17878) [`76eff3d`](withastro/astro@76eff3d) Thanks [@​ematipico](https://github.com/ematipico)! - Fixes browser heuristic caching for cached responses that include `Last-Modified` or `ETag` validators - [#​17833](withastro/astro#17833) [`413a6e7`](withastro/astro@413a6e7) Thanks [@​astro-factory](https://github.com/apps/astro-factory)! - Fixes prerender conflict warnings to correctly identify the route that first rendered a duplicate pathname, instead of misattributing the conflict to an unrelated route that merely matches the URL pattern - [#​17872](withastro/astro#17872) [`f7191cc`](withastro/astro@f7191cc) Thanks [@​jx-grxf](https://github.com/jx-grxf)! - Fixes Markdown images in content collections rendering an empty `srcset` attribute when no responsive candidates are generated. - [#​17755](withastro/astro#17755) [`157c500`](withastro/astro@157c500) Thanks [@​matthewp](https://github.com/matthewp)! - Fixes a bug where editing a content collection entry during `astro dev` on Windows kept serving stale content until the dev server was restarted. The data store now notifies the dev server directly after each write instead of relying only on the file watcher, which can miss the atomic rename that commits the write on some platforms. - Updated dependencies \[[`f8e9458`](withastro/astro@f8e9458), [`f8e9458`](withastro/astro@f8e9458)]: - [@​astrojs/internal-helpers](https://github.com/astrojs/internal-helpers)@0.11.0 - [@​astrojs/markdown-satteri](https://github.com/astrojs/markdown-satteri)@0.4.0 </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC41OS4zIiwidXBkYXRlZEluVmVyIjoiNDQuNTkuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TypeError: Invalid URL string) at server boot when the SSR server build is minified. Rolldown's minifier rewrites string literals as backtick template literals, but the@@ASTRO_MANIFEST_REPLACE@@replacement regex inplugin-manifest.tsonly matched single and double quotes, so the raw placeholder was left in the bundle.vite-plugin-server-islands.tsthat share the pattern.Testing
packages/astro/test/units/build/plugin-manifest.test.tscovering the backtick-quoted placeholder case, which reproduces the regression.Docs
Closes #17843