fix: keep Chat logprobs refusal separate - #500
Merged
Merged
Conversation
Chat logprobs.refusal was appended onto logprobs.content, so a same-wire encode no longer had a refusal array. Content and refusal stay separate on Chat. Gemini and Responses still receive the refusal tokens in their single logprobs list. A same-wire stream test was red (refusal key absent) and is green. The Gemini remap of logprobs.refusal still passes. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
enabled auto-merge (squash)
October 3, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A same-wire Chat response encode put
logprobs.refusaltokens intologprobs.contentand dropped therefusalarray. Those are sibling arrays on Chat Completions. Content and refusal stay separate. A refusal-only payload does not grow acontentarray.Gemini
logprobsResultand Responses logprobs still receive the refusal tokens, because those wires have one list. GeminiwebSearchQueriesstays dropped.Test
dest_chat_stream_logprobs_refusal_stays_on_chat_refusalanddest_chat_complete_logprobs_refusal_stays_on_chat_refusalfailed before the encode change: tokennopewas only underlogprobs.content, andlogprobs.refusalwas absent. Both pass after the change.dest_chat_stream_logprobs_refusal_remaps_dest_gemini_logprobs_resultstill passes.make checkpassed.