ApplyPolicyOverrides: never override per-device ClientIdentifier/SoftwareRepoURL (orphan guardrail)#73
Merged
Conversation
…tifier/SoftwareRepoURL
The MDM policy override (HKLM\SOFTWARE\Policies\Cimian) previously overrode
ClientIdentifier and SoftwareRepoURL in addition to InstallerTimeout. Both are
per-device / runtime values that preflight recomputes every cycle: ClientIdentifier
from the serial via Snipe-IT, SoftwareRepoURL from local-cache (Mars) vs central
availability. Letting a static policy win silently replaced the correct per-device
value — a stale placeholder ClientIdentifier ('EnrollClient') shipped in a profile
forced the whole fleet onto the enrollment manifest and ORPHANED devices (AB#3709).
Restrict policy override to genuinely fleet-static settings (InstallerTimeout only).
Guardrail so no future profile mistake can orphan the fleet via these fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident
v0.1.4's
ApplyPolicyOverridesreadsHKLM\SOFTWARE\Policies\Cimianand let it win over Config.yaml. It overrode ClientIdentifier (per-device, computed by preflight from serial→Snipe-IT) and SoftwareRepoURL (preflight's runtime Mars/central choice) in addition to InstallerTimeout. A stale placeholderClientIdentifier=EnrollClientshipped in the CimianPrefs profile therefore forced the whole fleet onto the enrollment manifest → orphaned devices (AB#3709).Fix
Restrict policy override to genuinely fleet-static settings — InstallerTimeout only. ClientIdentifier and SoftwareRepoURL are per-device/runtime values owned by preflight and are no longer policy-overridable, so no future profile mistake can orphan the fleet through them. Builds clean (
dotnet build -c Release, 0 warn/err).