ICal: recurring event edge case, and more timezone handling - #990
Merged
Conversation
One of the code paths for recurring event edge cases did not set the recurring_event_id. This would cause the event to later be deleted when cleaning up rows no longer relevant to the event.
Windows with trailing digits, empty, and digit-only (should have already been handled).
rgalanakis
force-pushed
the
ical-jan162026
branch
from
January 17, 2026 01:11
ddd155d to
dec501e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
=======================================
Coverage 97.62% 97.63%
=======================================
Files 509 509
Lines 32178 32225 +47
=======================================
+ Hits 31415 31462 +47
Misses 763 763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle more weird timezones
Windows with trailing digits, empty, and digit-only
(should have already been handled).
recurring id not set on some ical events
One of the code paths for recurring event edge cases
did not set the recurring_event_id.
This would cause the event to later be deleted when
cleaning up rows no longer relevant to the event.