Test foster parenting into a Document with an element child - #61396
Merged
Conversation
When the HTML parser's adjusted insertion location is a Document that already has an element child, the foster-parented node is dropped on the floor: "insert an element at the adjusted insertion location" aborts, and "insert a character" likewise for text. This is reachable when script reparents an on-stack <table> to be a Document's document element. - resources/scripted_foster01.dat: same-document element and text cases. - foster-parenting-into-document-with-element-child.html: the multi-document case, where the foster target is a separate Document. See whatwg/html#1706
6 tasks
zcorpan
approved these changes
Aug 17, 2026
noamr
approved these changes
Aug 17, 2026
annevk
added a commit
to whatwg/html
that referenced
this pull request
Aug 20, 2026
"Insert an element at the adjusted insertion location" previously aborted when it was "not possible to insert" the element, without defining what that meant. Replace it with an explicit condition — the adjusted insertion location is in a Document that already has an element child — mirroring the analogous check in "insert a character", and assert that the insertion then satisfies the DOM's "ensure pre-insert validity". Tests: web-platform-tests/wpt#61396 See #1706.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Aug 20, 2026
"Insert an element at the adjusted insertion location" aborted when it was "not possible to insert" the element, without defining what that meant. Also, the "initial" and "before html" insertion modes append a doctype and the html element directly to the document, which the DOM does not allow when it already has a doctype or element child. Also stop describing the node an insertion location finds itself in as an element, as it can be a Document or DocumentFragment node. Tests: web-platform-tests/wpt#61396 web-platform-tests/wpt#62020 See #1706.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the HTML parser's adjusted insertion location is a Document that already has an element child, the foster-parented node is dropped on the floor: "insert an element at the adjusted insertion location" aborts, and "insert a character" likewise for text. This is reachable when script reparents an on-stack
<table>to be a Document's document element.resources/scripted_foster01.dat: same-document element and text cases.foster-parenting-into-document-with-element-child.html: the multi-document case, where the foster target is a separate Document.See whatwg/html#1706