script: Fix assertion failure when stringifying cross-origin location object#58948
Merged
servo-wpt-sync merged 3 commits intoApr 3, 2026
Merged
Conversation
wpt-pr-bot
approved these changes
Apr 2, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
bdcb243 to
f3566ae
Compare
724e20c to
060b861
Compare
Add a WPT crash test that loads a cross-origin iframe and calls console.log on its location object, verifying that the browser does not crash. Signed-off-by: thebabalola <t.babalolajoseph@gmail.com>
Signed-off-by: thebabalola <t.babalolajoseph@gmail.com>
The test script was running in the head, before the body existed, so document.body.appendChild never added the iframe and the test timed out. Signed-off-by: thebabalola <t.babalolajoseph@gmail.com>
060b861 to
f2eaef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the assertion failure (
!JS_IsExceptionPending(*cx)) that happens whenconsole.log()is called on a cross-origin location object (e.g.console.log(frame.contentWindow.location)).The problem was that
maybe_stringify_dom_objectcallsToStringon cross-origin objects, which throws a JS exception via theDissimilarOriginLocationstringifier. That exception was never cleared, so subsequent JS API calls would hit the assertion.The fix refactors
console_argument_from_handle_valueusing an inner/outer function pattern based on @jdm's suggestion:Result<ConsoleArgument, ()>and returnsErr(())whenconsole_object_from_handle_valuereturnsNonefor an object, instead of falling through tostringify_handle_valuewhich could trigger the same crashErr, reports any pending JS exception viareport_pending_exception, and returns a fallbackConsoleArgumentFixes #43530
Reviewed in servo/servo#43844