Fix usage of RFC2119 words in privacy and security section - #685
Conversation
f653c70 to
d74a047
Compare
chrisn
left a comment
There was a problem hiding this comment.
Looks good, although I'm now wondering about this:
it SHOULD not be possible for a site to mutate a codec input or output
given the spec includes mitigations as part of the normative requirements. Also, we should probably add "This section is non-normative." to both these sections.
|
So we can't add rfc2119 verbs to non-normative sections see the manual of style, so we need to make a decision here. I think this recommendation is fair (although I'm now wondering why it mentions "output" as well), but I'm wondering what others think, @dsanders11, @youennf? I think there's agreement that mutating memory that's been passed to as an input is dangerous (that's why there are copies for now, and other mechanisms are being considered), but do implementations prevent mutating the output of codecs (e.g. mutating the encoded bytes after encoding, or mutating the media after decoding)? |
|
In general, we're likely to defer to you and Chris on the matters of legalese :) |
Yes, I agree. Another instance I just noticed is:
which could be rephrased as "We expect that user agents will mitigate this risk by" (to avoid "should" or "recommend") |
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 203730e Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Hang on, why merge this when there are unresolved comments? |
|
Thanks! I'll file a PR for #685 (comment) |
This fixes #648.
Preview | Diff