Skip to content

Enable configuration of AV1 screen content coding tools - #662

Merged
Djuffin merged 3 commits into
mainfrom
aboba-patch-4
Apr 27, 2023
Merged

Enable configuration of AV1 screen content coding tools#662
Djuffin merged 3 commits into
mainfrom
aboba-patch-4

Conversation

@aboba

@aboba aboba commented Apr 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fix for #646
Fix for #478

Rebase of #652

@aboba aboba mentioned this pull request Apr 11, 2023
Closed
@Djuffin

Djuffin commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

Is it really a per frame setting?
It seems that #652 does the same but on the VideoEncoderConfig level

@aboba

aboba commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator Author

During a screen sharing session, the content can change so that screen content coding might no longer be advisable. For example, a slide presentation could include an embedded video, or a user could shift to sharing another tab. libaom supports applying screen content coding on a per-frame basis, so having it applied per-frame in WebCodecs may make sense.

@Djuffin

Djuffin commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

WebCodecs Editors decision: let's put it into VideoEncoderConfig so VideoEncoder can explicitly refuse it if it's not supported.

@aboba

aboba commented Apr 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

PR redone to make it an encoder configuration option, as discussed in the Editor's meeting. This still allows screen content coding to be turned on/off in mid-stream by calling encoder.configure().

Djuffin
Djuffin reviewed Apr 18, 2023
View reviewed changes
Comment thread av1_codec_registration.src.html
@aboba

aboba commented Apr 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Discussed at 14 April 2023 MEDIA WG meeting: https://lists.w3.org/Archives/Public/public-media-wg/2023Apr/0007.html

@aboba

aboba commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator Author

Editor's meeting: merge it!

@Djuffin
Djuffin merged commit 3ec4530 into main Apr 27, 2023
@Djuffin
Djuffin deleted the aboba-patch-4 branch April 27, 2023 16:47
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
1595eeb 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
02c9820 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
406eceb 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
b9b7aad 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
4d7c9cb 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
9a2d7d3 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
39192a5 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
d458e3c 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
f352f81 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
d900e22 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
3b5f178 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
caec46c 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
81d2ca4 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
6909773 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
c01682b 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Apr 27, 2023
@Djuffin @github-actions
Merge pull request #662 from w3c/aboba-patch-4
1769c9d 
SHA: 3ec4530
Reason: push, by Djuffin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@aboba aboba mentioned this pull request Jun 13, 2023
Closed
@fippo

fippo commented Sep 9, 2023

Copy link
Copy Markdown
Contributor

Late comment but since this hasn't shipped yet... can we stop saying this is "forced" and instead say it gets enabled (i.e. enableScreenContentTools)?
Forcing may have implications e.g. when you try to do "force" it on a hardware encoder where it is not supported. Does that imply it should fail or should this simply not get enabled.

Wordsmithing ;-)

@fippo

fippo commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

(force... is used by the AV1 spec so keeping this consistent is good)

@fippo fippo mentioned this pull request Oct 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Djuffin Djuffin Djuffin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aboba @Djuffin @fippo