Ensure img/video/svg inside figure doesn't grow wider than the figure parent container - #5315
Open
patrickhlauke wants to merge 1 commit into
Open
Ensure img/video/svg inside figure doesn't grow wider than the figure parent container#5315patrickhlauke wants to merge 1 commit into
patrickhlauke wants to merge 1 commit into
Conversation
… parent container
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, due to the additional
1pxborder, wide images/videos/svgs inside a figure can end up 2 pixels wider than the parent<figure>container. This is not normally a problem, but results in an unsightly "bump" in focus outline when navigating with a keyboard and jumping to a section that contains one of these wide figures.Example: https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast#examples (make sure to navigate to it using the keyboard, to enable the focus outline)
Forcing the box-sizing to take into account the border fixes this.
Preview: https://deploy-preview-5315--wcag2.netlify.app/understanding/non-text-contrast#examples