editorial: Move the definition of display-mode back to APPMANIFEST. - #1039
Conversation
aarongustafson
left a comment
There was a problem hiding this comment.
CSS will want the export, no?
marcoscaceres
left a comment
There was a problem hiding this comment.
Approved, but let's make sure we merge them both a the same time.
|
Thanks for the export suggestions, @aarongustafson . I think you need to approve now that Marcos has merged it in. Also @marcoscaceres do you know what is going on with this validation error? It doesn't appear to be a problem with the changes to the html file: |
|
We think it's an issue at the W3C. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@mgiuca, I filed a bug for that error here: w3c/spec-prod#136 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
763f844 to
8f9e03a
Compare
|
Testing various browsers on a Mac, when a page has no manifest, and a browser tab is shown full-screen, browser controls remain visible but the menu bar is hidden. Chrome/Edge and Firefox treat this as fullscreen for Media Query purposes. Safari treats this as browser for Media Query purposes. |
8f9e03a to
c6a7e09
Compare
0c6c5db to
5edcfed
Compare
398f4ed to
49d61eb
Compare
|
@mgiuca, feel free to merge it? |
|
@marcoscaceres I haven't been merging this because I remember (>1 year ago.....) I got blocking comments out of band from @frivoal that I needed to action, and put this on the backburner. I'm trying to dig it up now (hence why I did a rebase) and finish this off. Edit: Ah yes, here's the relevant request. It's pretty vague but I'll make some changes and ping to see if they're happy. Edit: Here's the update to the PR on the MediaQueries side. No updates on the Manifest side. |
Closes w3c/csswg-drafts#7306. This text was moved out of the Manifest spec into CSS mediaqueries-5 in w3c/csswg-drafts#6343, along with the display-mode media feature. The actual definition of display mode belongs here, while the display-mode media feature remains in CSS mediaqueries-5.
Co-authored-by: Aaron Gustafson <aaron@easy-designs.net>
…lly point towards the CSS spec. Also linkify display-mode properly.
49d61eb to
d49f0cf
Compare
|
@mgiuca, let us know how/if/when we can proceed with merging this. |
|
Thanks for pinging the other PR. I would like to close this out but we should land both together. I will try to engage CSS people again... if we literally can't get in touch with them we could maybe just land this or modify it to create a parallel definition ("manifest display mode") but it is not ideal to do so. |
|
@mgiuca I pinged a few more CSS folks behind the scenes to see how we get it merged. I’ll report back. |
|
(Worst case, I don’t mind if we make a small mess and just merge this if we don’t hear back) |
|
Thanks so much for following this up, @marcoscaceres . It's been a LONG time and I'm glad to have things finally set up properly. |
|
No problem. Glad I could be of some help. |
|
Yes, thanks a ton Marcos 👍 |
|
@marcoscaceres is the WD version of the manifest spec supposed to update automatically? It hasn't for two weeks. From memory, it used to update automatically after about 24h but it seems stuck (it was last generated on April 10, right before this landed, but doesn't include this change). |
|
Will check what happened. |
|
Fixed... the publishing system was having issues. |
This text was moved out of the Manifest spec into CSS mediaqueries-5 in
w3c/csswg-drafts#6343, along with the display-mode media feature. The
actual definition of display mode belongs here, while the display-mode
media feature remains in CSS mediaqueries-5.
Closes w3c/csswg-drafts#7306.
This change (choose at least one, delete ones that don't apply):
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff