Adapt Gyroscope to the latest changes in the Generic Sensor API #10
Conversation
|
@anssiko PTAL |
|
Proposed to be added to the agenda for today's call. |
| Inline Github Issues: title | ||
| !Test Suite: <a href="https://github.com/w3c/web-platform-tests/tree/master/gyroscope">web-platform-tests on GitHub</a> | ||
| Boilerplate: omit issues-index, omit conformance | ||
| Default Biblio Status: current |
There was a problem hiding this comment.
Doing a link check, noticed the biblio fragments on L27-28 are broken. The Permissions spec has changed from underneath us. Upstream PR: w3c/sensors#157
There was a problem hiding this comment.
We don't need to block on this, let's fix these when the upstream PR lands.
There was a problem hiding this comment.
@pozdnyakov w3c/sensors#157 landed so you may want to sync accordingly.
index.bs
Outdated
| urlPrefix: https://w3c.github.io/sensors; spec: GENERIC-SENSOR | ||
| type: dfn | ||
| text: high-level | ||
| text: sensor subclass |
index.bs
Outdated
| Model {#model} | ||
| ===== | ||
|
|
||
| The Gyroscope's associated <a>Sensor subclass</a> |
index.bs
Outdated
| <a attribute for="GyroscopeReading">y</a> and | ||
| <a attribute for="GyroscopeReading">z</a> attributes to | ||
| the <a>current angular velocity</a> about the corresponding axis. | ||
| The Gyroscope extends sensor [=latest reading=] with three [=map/entries=] whose [=map/keys=] are "x", "y", "z" and whose [=map/values=] |
|
@tobie just committed to review this PR on the WG call. |
2c66ad9 to
6b2c6e3
Compare
index.bs
Outdated
| text: latest reading | ||
| text: default sensor | ||
| text: supported reporting mode; url: supported-reporting-modes | ||
| text: auto |
There was a problem hiding this comment.
You can also get rid of "auto" and "supported reporting mode" here.
index.bs
Outdated
| ===== | ||
|
|
||
| The Gyroscope's associated <a>Sensor subclass</a> | ||
| The Gyroscope's associated <a>Sensor</a> subclass |
index.bs
Outdated
| <a attribute for="GyroscopeReading">y</a> and | ||
| <a attribute for="GyroscopeReading">z</a> attributes to | ||
| the <a>current angular velocity</a> about the corresponding axis. | ||
| The Gyroscope extends sensor's [=latest reading=] with three [=map/entries=] whose |
There was a problem hiding this comment.
It's unclear what "The Gyroscope" refers to, here. Also why the uppercase?
I also would not use the term "extend" here.
There should be a [=latest reading=] per [=sensor=] of type gyroscope.
index.bs
Outdated
| ### The attribute ### {#gyroscope-attribute} | ||
|
|
||
| The <a attribute for="GyroscopeReading">x</a> attribute of the {{GyroscopeReading}} | ||
| The <a attribute for="Gyroscope">x</a> attribute of the {{Gyroscope}} |
There was a problem hiding this comment.
FYI: can write this as {{Gyroscope/x!!attribute}}. Your choice, however.
6b2c6e3 to
dfba09b
Compare
|
@tobie, thanks for your comments! Addressed in the latest patch. |
index.bs
Outdated
| ### The GyroscopeReading constructor ### {#gyroscope-reading-constructor} | ||
|
|
||
| ### The attribute ### {#gyroscope-reading-attribute} | ||
| ### The attribute ### {#gyroscope-attribute} |
There was a problem hiding this comment.
I'd title that differently. See how it's generally done in other specs: one title per attribute.
index.bs
Outdated
| ===== | ||
|
|
||
| The Gyroscope's associated <a>Sensor subclass</a> | ||
| The Gyroscope's associated {{Sensor}} subclass |
There was a problem hiding this comment.
Same capitalization issue here (and throughout the spec). Would be good to link these, too. Overall, it seems the model on the generic sensor side isn't clear enough. I need to work on it.
This patch gets rids of 'Reading' class and re-defines reading attributes using "latest reading" terminology from Generic Sensor API (https://w3c.github.io/sensors/#latest-reading).
dfba09b to
272d99b
Compare
|
@tobie, could you please take another look? |
This patch gets rids of 'Reading' class and re-defines reading attributes using "latest reading" terminology from Generic Sensor API (https://w3c.github.io/sensors/#latest-reading).