Skip to content

Return 0 when watchPosition() errors - #100

Merged
marcoscaceres merged 1 commit into
gh-pagesfrom
error_code
Jul 30, 2021
Merged

Return 0 when watchPosition() errors#100
marcoscaceres merged 1 commit into
gh-pagesfrom
error_code

Conversation

@marcoscaceres

@marcoscaceres marcoscaceres commented Jul 29, 2021

Copy link
Copy Markdown
Member

Closes #95 - @reillyeon, please see #95 (comment) for rationale for change.

The following tasks have been completed:

Implementation commitment:

  • WebKit - already returns 0.
  • Chromium - already returns 0.
  • Gecko

Preview | Diff

@marcoscaceres

Copy link
Copy Markdown
Member Author

This change is included in test web-platform-tests/wpt#29799

@marcoscaceres
marcoscaceres requested a review from reillyeon July 29, 2021 10:28

@reillyeon reillyeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly you can check off implementation commitment from WebKit and Chromium as they already implement this behavior.

@marcoscaceres

Copy link
Copy Markdown
Member Author

If I understand correctly you can check off implementation commitment from WebKit and Chromium as they already implement this behavior.

They implement the returning 0 part, yes - but not the "fully active" aspect of #78... so, to use a dated Simpsons reference, "partial credit" :)

@marcoscaceres
marcoscaceres merged commit 2c0c516 into gh-pages Jul 30, 2021
@marcoscaceres
marcoscaceres deleted the error_code branch July 30, 2021 01:26
@marcoscaceres marcoscaceres mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harmonize error code for watchPosition()

2 participants