ci: remove PR title check - #26072
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bd0307be5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3366320285
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Now that this path renders fetched commits without validating their parsed type, a commit title whose type is not in website/cue/reference/releases.cue's #SemanticType union, or an unparsable title, gets written as type: "ci"/type: null; vdev build docs-json runs cue export over all release CUE files while the schema still requires type: #SemanticType, so the first release containing a ci: or free-form title will generate a CUE file that fails the docs build. Since this PR removes the title workflow/template requirement specifically to allow those titles, either make the CUE schema/rendering handle an uncategorized type or keep a release-side fallback before rendering.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 996b994c74
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ca35e3aa2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ate breaking entries" This reverts commit 8ca35e3.
This reverts commit 3366303.
79dd691 to
46bb9e0
Compare
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46f158bada
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| docs: fix typos | ||
| ``` | ||
|
|
||
| #### Reviews & Approvals |
There was a problem hiding this comment.
Remove the stale Title TOC entry
After deleting the #### Title subsection from the GitHub Pull Requests section, the table of contents near the top of this file still contains [Title](#title). That link now points to no heading, so readers using the TOC get a broken jump; please remove the TOC entry or add a replacement heading for the remaining title guidance.
Useful? React with 👍 / 👎.
| @@ -44,23 +44,3 @@ Changes to CI, website, playground and similar are generally not considered user | |||
| - For example, you can run `git merge origin master` and `git push`. | |||
| - If this PR introduces changes Vector dependencies (modifies `Cargo.lock`), please | |||
| run `make build-licenses` to regenerate the [license inventory](https://github.com/vectordotdev/vrl/blob/main/LICENSE-3rdparty.csv) and commit the changes (if any). More details on the [dd-rust-license-tool](https://crates.io/crates/dd-rust-license-tool). | |||
There was a problem hiding this comment.
Update the remaining conventional-title docs
After removing the PR template/title guidance here, docs/DOCUMENTING.md still tells contributors that the release CUE commits: array is populated from conventional-commit PR titles and that PR titles must follow that spec. Contributors working on changelog/release docs now get contradictory instructions for non-conventional titles, so update that remaining paragraph to match the new release behavior.
Useful? React with 👍 / 👎.
Summary
Remove PR title enforcement. The
semantic.ymlcheck enforced a hand-maintained allowlist of Conventional Commits types that drifted from the PR template and added friction for external contributors and LLM-driven workflows. vdev's release path also enforced the same allowlist (Commit::validate/ALLOWED_TYPES), aborting releases for non-conventional PR titles. Both are removed; changelog fragment validation remains the source of truth for PR type.Changes
.github/workflows/semantic.yml(the "PR Title Check" workflow).ALLOWED_TYPESandCommit::validateinvdev/src/commands/release/generate_cue.rs). Changelog fragment validation is unchanged.render_cuenow omits thetypefield for commits whose parsed type is not in the schema's#SemanticTypeunion (e.g.ci) or that have no parseable type, and#Commit.typeis optional inwebsite/cue/reference/releases.cue, so the first release containing a free-form or non-semantic title no longer fails the docs build.AGENTS.mdand theTitlesection fromCONTRIBUTING.md.vector_semantic_ymlURL fromwebsite/cue/reference/urls.cue.Vector configuration
NA
How did you test this PR?
make check-markdowncargo test -p vdev generate_cuecargo fmt -p vdev -- --checkcargo clippy -p vdev -- -D warningsbash scripts/cue.sh vetIs this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
NA