Skip to content

ci: remove PR title check - #26072

Merged
thomasqueirozb merged 17 commits into
masterfrom
docs/agents-pr-title-format
Aug 10, 2026
Merged

ci: remove PR title check#26072
thomasqueirozb merged 17 commits into
masterfrom
docs/agents-pr-title-format

Conversation

@thomasqueirozb

@thomasqueirozb thomasqueirozb commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

Remove PR title enforcement. The semantic.yml check enforced a hand-maintained allowlist of Conventional Commits types that drifted from the PR template and added friction for external contributors and LLM-driven workflows. vdev's release path also enforced the same allowlist (Commit::validate/ALLOWED_TYPES), aborting releases for non-conventional PR titles. Both are removed; changelog fragment validation remains the source of truth for PR type.

Changes

  • Delete .github/workflows/semantic.yml (the "PR Title Check" workflow).
  • Remove the release-time conventional-commit type enforcement in vdev (ALLOWED_TYPES and Commit::validate in vdev/src/commands/release/generate_cue.rs). Changelog fragment validation is unchanged.
  • Preserve release CUE type compatibility: render_cue now omits the type field for commits whose parsed type is not in the schema's #SemanticType union (e.g. ci) or that have no parseable type, and #Commit.type is optional in website/cue/reference/releases.cue, so the first release containing a free-form or non-semantic title no longer fails the docs build.
  • Soften the PR template's title guidance from a strict "must be one of these" allowlist to a recommendation (title comment block removed).
  • Remove the PR title format section from AGENTS.md and the Title section from CONTRIBUTING.md.
  • Remove the now-dead vector_semantic_yml URL from website/cue/reference/urls.cue.

Vector configuration

NA

How did you test this PR?

  • make check-markdown
  • cargo test -p vdev generate_cue
  • cargo fmt -p vdev -- --check
  • cargo clippy -p vdev -- -D warnings
  • bash scripts/cue.sh vet

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

NA

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 7, 2026
@github-actions github-actions Bot added the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Aug 7, 2026
@thomasqueirozb
thomasqueirozb marked this pull request as ready for review August 7, 2026 20:15
@thomasqueirozb
thomasqueirozb requested review from a team as code owners August 7, 2026 20:15
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
@github-actions github-actions Bot added the domain: ci Anything related to Vector's CI environment label Aug 7, 2026
@thomasqueirozb thomasqueirozb changed the title docs: update AGENTS.md PR Title Format section docs: single-source PR title types in the PR template Aug 7, 2026
@thomasqueirozb thomasqueirozb changed the title docs: single-source PR title types in the PR template docss: single-source PR title types in the PR template Aug 7, 2026
@thomasqueirozb thomasqueirozb changed the title docss: single-source PR title types in the PR template docs: single-source PR title types in the PR template Aug 7, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8bd0307be5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/semantic.yml Outdated
Comment thread AGENTS.md Outdated
@thomasqueirozb thomasqueirozb changed the title docs: single-source PR title types in the PR template ci: remove PR title check Aug 10, 2026
@github-actions github-actions Bot added the domain: external docs Anything related to Vector's external, public documentation label Aug 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3366320285

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@github-actions github-actions Bot added the domain: vdev Anything related to the vdev tooling label Aug 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

let cue_text = render_release_cue(&new_version, &changelog_entries, &commits);

P2 Badge Preserve release CUE type compatibility

Now that this path renders fetched commits without validating their parsed type, a commit title whose type is not in website/cue/reference/releases.cue's #SemanticType union, or an unparsable title, gets written as type: "ci"/type: null; vdev build docs-json runs cue export over all release CUE files while the schema still requires type: #SemanticType, so the first release containing a ci: or free-form title will generate a CUE file that fails the docs build. Since this PR removes the title workflow/template requirement specifically to allow those titles, either make the CUE schema/rendering handle an uncategorized type or keep a release-side fallback before rendering.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 996b994c74

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread vdev/src/commands/release/generate_cue.rs Outdated
Comment thread vdev/src/commands/release/generate_cue.rs
Comment thread website/cue/reference/releases.cue Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ca35e3aa2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread vdev/src/commands/release/generate_cue.rs Outdated

@pront pront left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions github-actions Bot removed the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Aug 10, 2026
Comment thread website/cue/reference/releases/0.18.0.cue Outdated
@thomasqueirozb
thomasqueirozb force-pushed the docs/agents-pr-title-format branch from 79dd691 to 46bb9e0 Compare August 10, 2026 18:38
@thomasqueirozb

Copy link
Copy Markdown
Member Author

@codex review

@thomasqueirozb
thomasqueirozb added this pull request to the merge queue Aug 10, 2026
@jeff-morgan-dd jeff-morgan-dd self-assigned this Aug 10, 2026
@thomasqueirozb

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46f158bada

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread website/cue/reference/releases/0.18.0.cue
Comment thread CONTRIBUTING.md
docs: fix typos
```

#### Reviews & Approvals

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Remove the stale Title TOC entry

After deleting the #### Title subsection from the GitHub Pull Requests section, the table of contents near the top of this file still contains [Title](#title). That link now points to no heading, so readers using the TOC get a broken jump; please remove the TOC entry or add a replacement heading for the remaining title guidance.

Useful? React with 👍 / 👎.

@@ -44,23 +44,3 @@ Changes to CI, website, playground and similar are generally not considered user
- For example, you can run `git merge origin master` and `git push`.
- If this PR introduces changes Vector dependencies (modifies `Cargo.lock`), please
run `make build-licenses` to regenerate the [license inventory](https://github.com/vectordotdev/vrl/blob/main/LICENSE-3rdparty.csv) and commit the changes (if any). More details on the [dd-rust-license-tool](https://crates.io/crates/dd-rust-license-tool).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Badge Update the remaining conventional-title docs

After removing the PR template/title guidance here, docs/DOCUMENTING.md still tells contributors that the release CUE commits: array is populated from conventional-commit PR titles and that PR titles must follow that spec. Contributors working on changelog/release docs now get contradictory instructions for non-conventional titles, so update that remaining paragraph to match the new release behavior.

Useful? React with 👍 / 👎.

Merged via the queue into master with commit f4d6daa Aug 10, 2026
105 checks passed
@thomasqueirozb
thomasqueirozb deleted the docs/agents-pr-title-format branch August 10, 2026 19:42
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants