Merged
Conversation
Merged
Contributor
Author
|
Is it time to remove "AppVeyor" CI? |
Contributor
Yeah |
sylvestre
reviewed
Jan 7, 2023
tests/integration_test.rs
Outdated
| println!("release = {}", uname.release()); | ||
| println!("version = {}", uname.version()); | ||
| println!("machine = {}", uname.machine()); | ||
| println!("osname = {}", uname.osname()); |
Contributor
There was a problem hiding this comment.
maybe we could add per platform tests as in this case, we know what we will get, wdyt?
Contributor
Author
There was a problem hiding this comment.
I'll look at it tonight.
Contributor
Author
There was a problem hiding this comment.
I removed the redundant WinOS test, and added platform-specific tests of osname() for 'unix' and 'windows'.
Contributor
Author
|
Updated tests and rebased onto 'main'. |
Contributor
Author
|
I added two new WinOS tests: 1) compare version from DLL vs version from file against each other, and 2) confirm known version/os_name combinations. It looks like coverage improves from about 45% to 75%+. |
Contributor
Done |
Contributor
|
@rivy woud you like a new release with your changes? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of PR #26 (see the changes; I'll rebase with #26 is merged).
Move
osname()calculation down from uutilsunameinto platform-info to reduceunamecomplexity and add additional WinOS info to the result.With this and updates to
uname, a futureuname -awould look like...> uname -a Windows_NT HOSTNAME 10.0 19044 x86_64 MS/Windows (Windows 10)