ln: add error handling for hard link creation on directories - #9342
Merged
Conversation
Contributor
|
Lgtm (waiting for the ci now) |
cakebaker
reviewed
Nov 20, 2025
Comment on lines
+945
to
+951
| let result = scene.ucmd().args(&["dir", "dir_link"]).fails(); | ||
|
|
||
| assert!( | ||
| result | ||
| .stderr_str() | ||
| .contains("hard link not allowed for directory") | ||
| ); |
Contributor
There was a problem hiding this comment.
A detail: you can simplify the code a bit by using stderr_contains:
Suggested change
| let result = scene.ucmd().args(&["dir", "dir_link"]).fails(); | |
| assert!( | |
| result | |
| .stderr_str() | |
| .contains("hard link not allowed for directory") | |
| ); | |
| scene | |
| .ucmd() | |
| .args(&["dir", "dir_link"]) | |
| .fails() | |
| .stderr_contains("hard link not allowed for directory"); |
Contributor
Author
There was a problem hiding this comment.
totally missed that, adding it now
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
GNU tests seem to not pass still, even though I am mimicking the behaviour of my builtin ln. |
|
GNU testsuite comparison: |
Contributor
|
@FidelSch we replace the error message used in the GNU test in |
|
GNU testsuite comparison: |
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #9333